Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

made the default status of addons false #15722

Closed
wants to merge 1 commit into from
Closed

made the default status of addons false #15722

wants to merge 1 commit into from

Conversation

swastik959
Copy link
Contributor

  1. made the default status of addons false
  2. it fixes minikube addons list outputs wrong state for default addons #15710
    3.I simply changed the default status of the sevices as false
  3. if any discrepancy is there feel free to point out

@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jan 27, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @swastik959!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 27, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @swastik959. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: swastik959
Once this PR has been reviewed and has the lgtm label, please assign spowelljr for approval by writing /assign @spowelljr in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 27, 2023
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

spowelljr
spowelljr requested changes Jan 27, 2023
View reviewed changes
Copy link
Member

@spowelljr spowelljr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want the the storage provisioner addons to be disabled by default, we just want them to show as correctly disabled when minikube profile list is ran when they are in fact disabled.

@swastik959 swastik959 closed this Jan 28, 2023
@swastik959 swastik959 deleted the minikubec1 branch January 28, 2023 11:46
@swastik959
Copy link
Contributor Author

@spowelljr can you please let me know where to look for this problem

@spowelljr
Copy link
Member

@shubhbapna is assigned the issue #15710, if they don't have any activity on the issue by the end of this week then we can unassign the issue and you can take it.

@shubhbapna
Copy link
Contributor

@spowelljr sorry for the delay. I have opened a PR:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spowelljr spowelljr spowelljr requested changes

@prezha prezha Awaiting requested review from prezha

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

Assignees
No one assigned
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

minikube addons list outputs wrong state for default addons
5 participants
@swastik959 @k8s-ci-robot @minikube-bot @spowelljr @shubhbapna